podman unshare keep exit code #11513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
This is how it should handle these errors: (The same way podman run and podman exec do.) podman unshare --bogus |
edsantiago
reviewed
Sep 9, 2021
test/e2e/unshare_test.go
Outdated
| @@ -47,8 +47,7 @@ var _ = Describe("Podman unshare", func() { | |||
| session := podmanTest.Podman([]string{"unshare", "readlink", "/proc/self/ns/user"}) | |||
| session.WaitWithDefaultTimeout() | |||
| Expect(session).Should(Exit(0)) | |||
| ok, _ := session.GrepString(userNS) | |||
| Expect(ok).To(BeFalse()) | |||
| Expect(session.OutputToString()).To(ContainSubstring(userNS)) | |||
There was a problem hiding this comment.
Looks like this should be Not()?
|
@rhatdan Thanks, I didn't know ENOENT and EPERM get special exit codes. This is how it looks now: $ bin/podman unshare --bogus
Error: unknown flag: --bogus
125
$ bin/podman unshare /usr/bin/bogus
Error: fork/exec /usr/bin/bogus: no such file or directory
127
$ bin/podman unshare bogus
Error: exec: "bogus": executable file not found in $PATH
127
$ bin/podman unshare /etc
Error: fork/exec /etc: permission denied
126
$ bin/podman unshare bash -c "exit 52"
52 |
Luap99
force-pushed
the
unshare
branch
2 times, most recently
from
7c85305 to
fd318f5
Compare
|
Test failures are because of #11521 |
|
Good to rebase, now that that is fixed? |
|
LGTM |
In case the command inside the podman unshare env failed podman unshare always exits with 125 and prints `Error: exit status 125`. This is a bad user experience and makes it difficult to use in scripts which could expect certain exit codes. This commit makes sure podman unshare uses the same exit code as the command and does not print the useless `exit status X` message. Also to match podman run/exec it should return 126 for EPERM and 127 for ENOENT. Signed-off-by: Paul Holzinger <[email protected]>
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
LGTM |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the command inside the podman unshare env failed podman unshare
always exits with 125 and prints
Error: exit status 125. This is abad user experience and makes it difficult to use in scripts which could
expect certain exit codes.
This commit makes sure podman unshare uses the same exit code as the
command and does not print the useless
exit status Xmessage.